Refactor Select to handle grouped options in buildValueObj#2500
Merged
Conversation
Contributor
Author
|
@farhanlatheef _a Please review. |
Contributor
Contributor
|
@VedanshAgrawal22 _a Add a description and merge the PR. |
Contributor
|
@VedanshAgrawal22 Also please add a jest test for this. |
VedanshAgrawal22
deleted the
2499-fix-issue-with-initial-values-not-being-displayed-when-using-grouped-options-in-formik-select
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Select#2499Description
This PR makes changes to handle the case when the options passed to the Select component are grouped.
The
buildValueObjmethod has been modified to get the deeply nested options after checking for grouping.This change fixes issues with initial values not being displayed in the dropdown when using formik.
Checklist
- [ ] I have made corresponding changes to the documentation.- [ ] I have updated the types definition of modified exports.- [ ] I have added tests that prove my fix is effective or that my feature works.- [ ] I have added properdata-cyanddata-testidattributes.patch/minor/major- If package publishis required).
Reviewers